Life is Feudal Official Forum

[Fawkinay]

The aim of the mod is to reduce the size of the inventory window.
If many people don't want this resize anymore, I might include a setting in the configuration file.

+1 request for a setting to disable Inventory window resizing.

Thank you!

[Dunkhan]

I noticed the herb sorting was bugged - namely, if there are more than maxstackcount (default 15) herbs in a row, they are invisible.

I investigated and found that the algorithm that makes the y offset when the row is full is totally bugged and is setting the y value of the herb to infinity.

I also found other random cruft that appeared either to have no effect or to do something strange that I didn't understand.

I rewrote the code locally so I could use it. But I thought it might be nice to share with the devs/other users so here it is.

In HerbToolConfig.cs you change this block ("..." is a placeholder for the old code)

Code: Select all

function InventoryOrganizer::sortHerb(%this, %herbId, %invItem, %stackCount){...}

with this one:

Code: Select all

function InventoryOrganizer::sortHerb(%this, %herbId, %invItem, %stackCount){
   %usedcount = %stackCount;
   %yoffset = 0;
   %xoffset = 0;

   for (; %usedcount>=InventoryOrganizer.maxstackcount; %i++){
   
      %usedcount-=InventoryOrganizer.maxstackcount;
      %yoffset+=InventoryOrganizer.stackSpace;
   }
   
   %row = %herbId;
   %x = InventoryOrganizer.startX + (InventoryOrganizer.stackSpace*%usedcount)+%xoffset;
   %y = InventoryOrganizer.startY + (%row*InventoryOrganizer.spaceY) + %yoffset;
   %pos = %x @ " " @ %y;
   
   %invItem.position = %pos;
}

Side effect:
1. The variable "rows" is no longer used. There will automatically be the same number of rows as the highest number you use for herbId (default 6). Changing this variable will no longer have any effect.

Note to devs:
InventoryOrganizer.factorY and InventoryOrganizer.factorX were returning nothing, so dividing by them was resulting in infinite coordinates. This might be because of how I set up my main config but I could not find a place to set these values. Either way the way I set it up in the code above is cleaner and more sensible imo.

for anyone that is curious, the settings I use to keep as many herbs in the window as possible while not covering any of the count/quality indicators are:

Code: Select all

startX = 2;
startY = 32;
stackSpace = 25;   
maxstackcount = 13;
spaceY = 64;

[Teah]

Thank you so very much for this mod its amazing.

[Wessller]

Question:

The only way to get this mod to automatically sort Herbs, is to modify the file "HerbToolConfig.cs" for all 66 herbs?

No automatic way?

[NimRodelle]

So what I'm trying to figure out is why the mod isn't utilizing all of the available inventory window space to sort things?



The last object being sorted is that stack of 460 clay, everything else is just free floating in the window.

Nim

[Rustyrocks6969]

Hey, so this mod is not getting worked on anymore. http://skunkfu.net/sf-mods/ Take a look at SF-Mods

[Mattia.bonaducci]

Just do add something in this topic, I actually maintaned this mod for my (and my guild use) and recently I decided to work on it a bit more.
I have version from march which I optimized for Ellian (known problem with regional resources) but I'm not sure if it was ever released in EMP.

I actually wanted to fix a few issues related to custom inventory sizes, mostly to fix usage of full container space regardless of it's size (works with custom image files extending it as well). I think I'll "release" it soon for my guild and I can post it here as well if someone is interested.

@NimRodelle It's hardcoded to stop sorting if you hit 400px height. Does not matter how high is the window and it stopped after first object in next line. Everything else was not sorted. I want to do something that will be a bit more useful in big warehouses etc.

[Xelat84]

Not all items are sorted when there is too many items in inventory/container. (or may be it has some another reason)