Database skill_type.parent = null not working?

Have some feedback for Life is Feudal? Post it here!
User avatar
Azzerhoden
Alpha Tester
 
Posts: 1621
Joined: 08 May 2014, 17:44

Database skill_type.parent = null not working?

Post by Azzerhoden » 03 Jul 2015, 23:43

Not sure this is a bug or by design. If a bug I'll file on Mantis, but here's the situation:

If I go into the skill_type table, and set the parent value for, as an example, Mining (ID 2), to <null>, and attempt to create a character, a "Character creation process error (code=1024)" error is generated if prospecting is set to 30 or above for the new character. If set to less than 30, then the character is generated.

Is there somewhere that I can turn this off? Is this an error? This happens with any of the second skill nodes. Any 3rd-5th node has no issue, so it is only with the creation of the character. I suspect the code generates an error if no value is returned when getting the child skill ID, rather than checking to see if there is a return value.
| - Alpha Tester and Zealous Believer
Image

Kingdom of Hyperion founding Duchy - A practical RP Community est. 1999 - Apply Today!

User avatar
Azzerhoden
Alpha Tester
 
Posts: 1621
Joined: 08 May 2014, 17:44

Re: Database skill_type.parent = null not working?

Post by Azzerhoden » 04 Jul 2015, 00:41

Also- are there any tables that get populated on character creation AFTER the characters skills are updated? I'd like to avoid adding in duplicate rows of skills by creating a customer trigger. Right now the character creation process doesn't check for a skill to already exist (which makes sense), but writing a trigger against either character or character_wounds to insert a skill results in some duplicate skills if the parent skill is above 30.

Was thinking of adding a unique index against characterID and skillID for the skills table, but I don't know if that would cause an error at character creation. Guess I could play with it and find out.
| - Alpha Tester and Zealous Believer
Image

Kingdom of Hyperion founding Duchy - A practical RP Community est. 1999 - Apply Today!


Hoshiqua
Alpha Tester
 
Posts: 1057
Joined: 18 Jan 2014, 14:48

Re: Database skill_type.parent = null not working?

Post by Hoshiqua » 04 Jul 2015, 09:06

You don't need to. If you want to make a skill independant, just set the parent as 0, not null. Look at the first skills in the skill lines or the independant skills, you'll see how they are laid out..

But it has to be done both server AND client side in order for it to work properly.

User avatar
Azzerhoden
Alpha Tester
 
Posts: 1621
Joined: 08 May 2014, 17:44

Re: Database skill_type.parent = null not working?

Post by Azzerhoden » 04 Jul 2015, 23:21

Hoshiqua wrote:You don't need to. If you want to make a skill independant, just set the parent as 0, not null. Look at the first skills in the skill lines or the independant skills, you'll see how they are laid out..

But it has to be done both server AND client side in order for it to work properly.


It may have worked this way in the past, but I can confirm that by setting the server side XML parent to 0, and the database skill_type.Parent to <null>, I can use those skills even though I do not have the parent skill. In the skillbook they are also active.

I've found that setting the client xml file to 0 causes skills to appear on new lines in the skill book.

Again, the only time this is not the case, is on character creation, where the error is thrown when it attempts to add the second tier skill and the skill_type.Parent value is <null>
| - Alpha Tester and Zealous Believer
Image

Kingdom of Hyperion founding Duchy - A practical RP Community est. 1999 - Apply Today!


Hoshiqua
Alpha Tester
 
Posts: 1057
Joined: 18 Jan 2014, 14:48

Re: Database skill_type.parent = null not working?

Post by Hoshiqua » 05 Jul 2015, 17:14

If it doesn't work then I don't know.. I did successfully remove the skill lines in the past, and you could create a character just fine. The only problem was that the skillbook UI was completly messed up.

User avatar
Azzerhoden
Alpha Tester
 
Posts: 1621
Joined: 08 May 2014, 17:44

Re: Database skill_type.parent = null not working?

Post by Azzerhoden » 09 Jul 2015, 19:24

Well, tried to remove all pre-requisites, and found another bug where some skills are still not unlocked (but others in the chain are).

Both filed on Mantis. For the MMO these would not be bugs, but for YO it removes the ability for admins to setup a server to their own specifications.

Bug #1: https://lifeisfeudal.com/mantis/view.php?id=3460
Bug #2: https://lifeisfeudal.com/mantis/view.php?id=3456
| - Alpha Tester and Zealous Believer
Image

Kingdom of Hyperion founding Duchy - A practical RP Community est. 1999 - Apply Today!

Return to Feedback Section

cron