Life is Feudal Official Forum

[Libeer]

Hey,

I love the idea and concept of the herbal garden. The 9 horus might be not so great to get a schedule around but should not be a big problem. I'm so happy it's finally here.

So for people who do not know how it works: You put in the herb you want to plant, put in 10 water and anywhere between 0 and 6 fertilizer; then you click plant, and it has a 9 hour timer.

Now the issue is that when the server does a scheduled restart or if it crashes, everything is still in it, but you have to reclick the plant option. Now on 90% or more of the servers, there are either regular restarts that keep the crashes at bay, or it crashes a lot, or a combination. So this makes the use of the herbal garden impossible.

My suggestion on how to fix this, at least for the lif:yo ga, is either making it work like tanning tubs/drying racks that it finishes automatically, which might be vastly overpowered. Or make it like farming so it doesn't care about crashes/restarts, it works on the in-game date on when it's ready, making it maybe 4 day-night cycles?

I love the concept, it's just unusable with the stability of servers.

[Culdych]

Yep, as they stand now they are essentially just decoration. There is now way i will ever get them to finish a cycle on the server i play on. I'd preffer it if they worked like farms rather than drying racks, flux is the defacto currency on most servers so making it too easy would be detrimental.

[Xarven]

Same here. With 3 restarts and maybe 1-2 server crashes there is no way to gather herbs with this. Cause everytime it resets the garden.

[Boodykea]

...which explains my sadness this a.m when I checked my herb garden this morning after server restart.

[Tonytopping2002]

Yep, as they stand now they are essentially just decoration. There is now way i will ever get them to finish a cycle on the server i play on. I'd preffer it if they worked like farms rather than drying racks, flux is the defacto currency on most servers so making it too easy would be detrimental.

I agree with this totally. Or at least for the time being could you hotfix the timer to say..... 3hrs with Half the yield, until you can get it to work properly. Was so excited and appreciate the idea. But it is a bust as it stands

[Wiz12268]

Same here. With 3 restarts and maybe 1-2 server crashes there is no way to gather herbs with this. Cause everytime it resets the garden.

well the upside is if those happened on different in game days your crops are growing trees are growing and replenishing and claims are expanding.

Herb garden being broken is a minor issue, the growth cycle timer being broken is a game breaking issue.

Herb gardens are OP anyway. I made 11 and have only had a chance to harvest them 3 times and got enough herbs to make almost 750 flux. 45 herbs per plot is way too many it would have taken a few months of real life time before these things to gather enough herbs and trade or make with guild mates to get half that many flux. Now you make a few hope your server doesnt crash and then xx amount of hours later depending on your settings you go reap mountains of flux or naptha.

[SamInside]

Server owners can be happy that servers are crashing so often an gardens time is not saved @db

On the one hand it destroys the ingamcurrency herbs completly. On the other hand there is a rly bad bug. Sometimes you wont get only 19 or 45 herbs from a garden. You get more than 4000000 herbs per run.

So i suggest each server owner to disable them until a fix is ready. For example by change the recipe costs to very high values and deleting all existent gardens on the map.

[J3ron1mo]

Hey folks,

after having the same problem on our server and reading this here, I sat down and wrote a Stored Procedure which will make the herbal garden grow if the correct contents are found inside (10 water, 1 dung, 1 herb). 'Grow' in this case means add another 44 herbs of that type and remove the water and dung.
This then can be called during server restart, which in our case is the daily restart in the morning when normally the plants would grow anyway.

To call it (for example from dump.sql):

Code: Select all

CALL `p_grow_herbal_garden`();

The stored procedure 'p_grow_herbal_garden':

Code: Select all

BEGIN
   DECLARE done INT;
   DECLARE herb_garden_container_id INT;

   DECLARE curs CURSOR FOR SELECT ID FROM containers where ObjectTypeID = 1353;  -- Herbal Garden
   DECLARE CONTINUE HANDLER FOR NOT FOUND SET done = 1;
         
   OPEN curs;
   
   SET done = 0;
   REPEAT
      FETCH curs INTO herb_garden_container_id;
         
      IF (SELECT
            EXISTS (SELECT * from items WHERE containerID = herb_garden_container_id
            AND ObjectTypeID = 204 AND items.Quantity = 10) -- 10 water
         AND
            EXISTS (SELECT * from items WHERE containerID = herb_garden_container_id
            AND ObjectTypeID = 1032 AND items.Quantity = 1) -- 1 dung
         AND
            EXISTS (SELECT * from items WHERE containerID = herb_garden_container_id
            AND ObjectTypeID >= 684 AND ObjectTypeID <= 750 AND Quantity = 1)  -- 1 herb
         ) = 1
      THEN
         -- remove water and dung
         DELETE FROM items WHERE containerID = herb_garden_container_id
            AND (ObjectTypeID = 204 OR ObjectTypeID = 1032);
         -- set herb quantity to 45
         UPDATE items SET Quantity = 45 WHERE containerID = herb_garden_container_id
            AND ObjectTypeID >= 684 AND ObjectTypeID <= 750;            
      END IF;
   UNTIL done END REPEAT;
   
   CLOSE curs;
END

[K475u]

Hey folks,

after having the same problem on our server and reading this here, I sat down and wrote a Stored Procedure which will make the herbal garden grow if the correct contents are found inside (10 water, 1 dung, 1 herb). 'Grow' in this case means add another 44 herbs of that type and remove the water and dung.
This then can be called during server restart, which in our case is the daily restart in the morning when normally the plants would grow anyway.

To call it (for example from dump.sql):

Code: Select all

CALL `p_grow_herbal_garden`();

The stored procedure 'p_grow_herbal_garden':

Code: Select all

BEGIN
   DECLARE done INT;
   DECLARE herb_garden_container_id INT;

   DECLARE curs CURSOR FOR SELECT ID FROM containers where ObjectTypeID = 1353;  -- Herbal Garden
   DECLARE CONTINUE HANDLER FOR NOT FOUND SET done = 1;
         
   OPEN curs;
   
   SET done = 0;
   REPEAT
      FETCH curs INTO herb_garden_container_id;
         
      IF (SELECT
            EXISTS (SELECT * from items WHERE containerID = herb_garden_container_id
            AND ObjectTypeID = 204 AND items.Quantity = 10) -- 10 water
         AND
            EXISTS (SELECT * from items WHERE containerID = herb_garden_container_id
            AND ObjectTypeID = 1032 AND items.Quantity = 1) -- 1 dung
         AND
            EXISTS (SELECT * from items WHERE containerID = herb_garden_container_id
            AND ObjectTypeID >= 684 AND ObjectTypeID <= 750 AND Quantity = 1)  -- 1 herb
         ) = 1
      THEN
         -- remove water and dung
         DELETE FROM items WHERE containerID = herb_garden_container_id
            AND (ObjectTypeID = 204 OR ObjectTypeID = 1032);
         -- set herb quantity to 45
         UPDATE items SET Quantity = 45 WHERE containerID = herb_garden_container_id
            AND ObjectTypeID >= 684 AND ObjectTypeID <= 750;            
      END IF;
   UNTIL done END REPEAT;
   
   CLOSE curs;
END

Heyy Mate i CALLed the Procedure via Patrch SQL

Like:

Code: Select all

-- Herb Garden

DROP PROCEDURE IF EXISTS  p_grow_herbal_garden;
CREATE PROCEDURE `p_grow_herbal_garden`(
   IN `inID` INT UNSIGNED
)
BEGIN
   DECLARE done INT;
   DECLARE herb_garden_container_id INT;

   DECLARE curs CURSOR FOR SELECT ID FROM containers where ObjectTypeID = 1353;  -- Herbal Garden
   DECLARE CONTINUE HANDLER FOR NOT FOUND SET done = 1;
         
   OPEN curs;
   
   SET done = 0;
   REPEAT
      FETCH curs INTO herb_garden_container_id;
         
      IF (SELECT
            EXISTS (SELECT * from items WHERE containerID = herb_garden_container_id
            AND ObjectTypeID = 204 AND items.Quantity = 10) -- 10 water
         AND
            EXISTS (SELECT * from items WHERE containerID = herb_garden_container_id
            AND ObjectTypeID = 1032 AND items.Quantity = 1) -- 1 dung
         AND
            EXISTS (SELECT * from items WHERE containerID = herb_garden_container_id
            AND ObjectTypeID >= 684 AND ObjectTypeID <= 750 AND Quantity = 1)  -- 1 herb
         ) = 1
      THEN
         -- remove water and dung
         DELETE FROM items WHERE containerID = herb_garden_container_id
            AND (ObjectTypeID = 204 OR ObjectTypeID = 1032);
         -- set herb quantity to 45
         UPDATE items SET Quantity = 50 WHERE containerID = herb_garden_container_id
            AND ObjectTypeID >= 684 AND ObjectTypeID <= 750;           
      END IF;
   UNTIL done END REPEAT;
   
   CLOSE curs;
END;

But now if anyone Plants som herbs they are grown instant..

How do i call the procedure only on server restart 1 Times ! So if no one looses Herbs at a Server Crash eg ?